Extend sysmonitor functionality to wait for host daemons by fastiuk · Pull Request #1363 · sonic-net/SONiC

fastiuk · 2023-06-19T02:26:12Z

Configure system-ready feature state
Allow host daemons to report it's status

Code PRs:

PR title	state	context
[System ready] Extend sysmonitor functionality to wait for host daemons
[System ready] Report ready status to Sysmonitor daemon
[System ready] Report ready state to Sysmonitor daemon
[System ready] Extend sysmonitor functionality to wait for host daemons

zhangyanzhao · 2023-06-20T16:13:15Z

sonic community review recordings, the meeting was ended by mistake in the middle, so we have two recordings:
part 1: https://zoom.us/rec/share/YD1eE3Agsa_DVyIgXEO_qCiKphPg67nDDPtkaFGcuGr6MuhW6CvYwdNkvzYX66yV.DsPiDYdWvgsOg4Va
part 2: https://zoom.us/rec/share/Aa3ey00NjX5mF9w4vcwJGmVakued75dZ5I33prQCm1YLLM4zxKNU5JmnXHNgQFhY.-6FnIa3dDwudbhyI

* Configure system ready feature state * Allow host daemons to report its status Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>

liat-grozovik · 2023-08-24T10:16:23Z

@zhangyanzhao this HLD was reviewed in the community as avaialble for 2 months now.
if we dont have reviewers assigned nor feedback provided i believe we should assume this is approved.

@fastiuk please track. when do you expect the code PRs to be available?

qiluo-msft · 2023-09-18T07:05:31Z

Combatibility with application extension framework.

typo? #Closed

Refers to: doc/system_health_monitoring/system-ready-HLD.md:105 in d2b8071. [](commit_id = d2b8071, deletion_comment = False)

qiluo-msft · 2023-09-18T07:08:08Z

doc/system_health_monitoring/system-ready-HLD.md

            }
 ```

+The feature configuration is controlled by `sysready_state` field of `DEVICE_METADATA` table.


DEVICE_METADATA

why not use FEATURE table? #Closed

It used. But the parameter you highlighted is used to control the global feature state. enabled or disabled. With disabled feature, it will wait for the readiness of only one component - swss "PortInitDone"

If the FEATURE is enabled, why allow user to disable it here?

FEATURE table controls the effect of a specific feature (sonic app extension) on sysmonitor. So it will, or won't have an effect on system startup flow.
But DEVICE_METADATA table controls the system ready state globally, with disabled state it won't wait for any daemon enabled in FEATURE table, but only for swss's "PortInitDone"

fastiuk · 2023-09-18T22:05:58Z

Combatibility with application extension framework.

typo?

Refers to: doc/system_health_monitoring/system-ready-HLD.md:105 in d2b8071. [](commit_id = d2b8071, deletion_comment = False)

I don't think so. Since affect on system readiness is configured using FEATURE table as well as JSON file, it is legit compatibility,

qiluo-msft · 2023-09-20T23:21:25Z

Combatibility with application extension framework.

Typo on Combatibility?

In reply to: 1722855007

Refers to: doc/system_health_monitoring/system-ready-HLD.md:105 in d2b8071. [](commit_id = d2b8071, deletion_comment = False)

prgeor

@fastiuk who will monitor sysmonitor task if its healthy? Its a chicken-egg problem....I think its better to montior the health of the system outside the sonic...

fastiuk · 2023-10-02T06:19:16Z

Combatibility

Oh, yes :) Will fix

fastiuk · 2023-10-02T06:19:46Z

@fastiuk who will monitor sysmonitor task if its healthy? Its a chicken-egg problem....I think its better to montior the health of the system outside the sonic...

As part of this feature - no one

liat-grozovik · 2023-12-03T13:23:40Z

@prgeor any further comments or this HLD can be approved and merged?
@fastiuk do you have code PRs that you can add to the PR description for tracking?

fastiuk · 2023-12-03T13:32:45Z

@fastiuk do you have code PRs that you can add to the PR description for tracking?

Not yet, planning to have it on Monday

qiluo-msft · 2024-01-22T02:55:25Z

Combatibility with application extension framework.

Could you fix?

In reply to: 1728546769

Refers to: doc/system_health_monitoring/system-ready-HLD.md:105 in d2b8071. [](commit_id = d2b8071, deletion_comment = False)

Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>

fastiuk · 2024-01-29T12:58:52Z

Comments addressed. Please approve and merge

zhangyanzhao · 2024-02-05T06:47:35Z

@fastiuk can you please help to add the code PRs by referring to #806 ? Thanks.

qiluo-msft

LGTM. Please check with other reviewers.

fastiuk · 2024-02-19T13:24:46Z

@prgeor could you please take a look again? As you have done review in the past?

zhangyanzhao · 2024-04-26T23:20:51Z

@fastiuk can you please help to provide the code PR in this HLD? Thanks.

fastiuk · 2024-04-28T00:20:44Z

@fastiuk can you please help to provide the code PR in this HLD? Thanks.

Added

zhangyanzhao · 2024-05-22T16:36:10Z

Still target 202405 release, code PRs need be reviewed and Nvidia will help on the code PR review. @liat-grozovik

zhangyanzhao · 2024-05-22T16:36:46Z

Existing test cases will be used for regression testing.

zhangyanzhao · 2024-06-04T17:28:36Z

code PRs are still open, move to backlog for future release.

fastiuk changed the title ~~Extend sysmonitor functionality~~ Extend sysmonitor functionality to wait for host daemons Jun 19, 2023

Extend sysmonitor functionality

d2b8071

* Configure system ready feature state * Allow host daemons to report its status Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>

fastiuk force-pushed the dev-extend-system-ready branch from 42b0666 to d2b8071 Compare June 21, 2023 19:19

qiluo-msft reviewed Sep 18, 2023

View reviewed changes

qiluo-msft requested a review from prgeor September 18, 2023 07:08

prgeor reviewed Sep 26, 2023

View reviewed changes

Fix typo in System ready HLD

8342fb2

Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>

qiluo-msft approved these changes Feb 5, 2024

View reviewed changes

prgeor approved these changes Mar 4, 2024

View reviewed changes

prgeor merged commit ce313db into sonic-net:master Mar 4, 2024

liat-grozovik assigned fastiuk Apr 17, 2024

This was referenced May 19, 2024

[System ready] Extend sysmonitor functionality to wait for host daemons sonic-net/sonic-buildimage#18817

Open

[System ready] Extend sysmonitor functionality to wait for host daemons sonic-net/sonic-utilities#3294

Open

zhangyanzhao mentioned this pull request Dec 10, 2024

Extend sysmonitor functionality to wait for host daemons #1756

Closed

Conversation

fastiuk commented Jun 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zhangyanzhao commented Jun 20, 2023

Uh oh!

liat-grozovik commented Aug 24, 2023

Uh oh!

qiluo-msft commented Sep 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qiluo-msft Sep 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fastiuk Sep 18, 2023

Choose a reason for hiding this comment

Uh oh!

qiluo-msft Sep 20, 2023

Choose a reason for hiding this comment

Uh oh!

fastiuk Oct 2, 2023

Choose a reason for hiding this comment

Uh oh!

fastiuk commented Sep 18, 2023

Uh oh!

qiluo-msft commented Sep 20, 2023

Uh oh!

prgeor left a comment

Choose a reason for hiding this comment

Uh oh!

fastiuk commented Oct 2, 2023

Uh oh!

fastiuk commented Oct 2, 2023

Uh oh!

liat-grozovik commented Dec 3, 2023

Uh oh!

fastiuk commented Dec 3, 2023

Uh oh!

qiluo-msft commented Jan 22, 2024

Uh oh!

fastiuk commented Jan 29, 2024

Uh oh!

zhangyanzhao commented Feb 5, 2024

Uh oh!

qiluo-msft left a comment

Choose a reason for hiding this comment

Uh oh!

fastiuk commented Feb 19, 2024

Uh oh!

zhangyanzhao commented Apr 26, 2024

Uh oh!

fastiuk commented Apr 28, 2024

Uh oh!

zhangyanzhao commented May 22, 2024

Uh oh!

zhangyanzhao commented May 22, 2024

Uh oh!

zhangyanzhao commented Jun 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fastiuk commented Jun 19, 2023 •

edited

Loading

qiluo-msft commented Sep 18, 2023 •

edited

Loading

qiluo-msft Sep 18, 2023 •

edited

Loading